Fix look and feel for LDAP sync
What does this MR do and why?
There are some positioning/spacing issues with the pages related to the LDAP sync feature. This MR fixes the following:
On the Settings
-> LDAP Synchronization
page, the following issues were fixed:
- A search bar is shown at the top, but it's disabled and not usable. It has been removed.
- The group selector dropdown always shows gray text even when a dropdown item is selected. It now shows gray text when the placeholder text is shown, and black text when a selection is made.
- When there are no synchronizations configured, the
No sync configured
text has no padding around it. - When there are synchronizations configured, the Remove button is top aligned. It has been changed to center aligned.
Before:
No synchronizations configured | Synchronizations configured |
---|---|
After:
No synchronizations configured | Synchronizations configured |
---|---|
On the Manage
-> Members
page, an info alert is shown when LDAP synchronizations are configured. The following issues with it were fixed:
- There is no padding between the message and the bullet list below it. Padding has been added.
- There is no padding between the bullet list items. Padding has been added.
- The sync status message is top-aligned. It has been changed to center aligned.
- There is no padding between the sync button and the status message. Padding has been added.
Before | After |
---|---|
How to set up and validate locally
- In your GDK root folder, edit
gdk.yml
and add the following top-level entry:
openldap:
enabled: true
- Run
gdk reconfigure
, then restart your GDK. - (optional) Go to
<gdk_root>/gitlab-openldap
, then runmake clean default
to populate the database with LDAP data. - Go to any group ->
Settings
->LDAP Synchronization
. - Verify that the design matches the MR description.
- Go to
Manage
->Members
. - Verify that the alert design matches the MR description.
Related to #464104 (closed)
Edited by Daniel Tian