Skip to content

Removes the size prop from the HAML BadgeComponent

What does this MR do and why?

Removes the size prop from the HAML Pajamas::BadgeComponent & gl_badge_tag

This is a follow-up to GlLabel: Remove size property from codebase (!129915 - merged) where we already removed the properties for the Vue integration. As we removed sizes from Badges to render it in a single size this property is now useless.

  • It removes size props from BadgeComponent
  • Updates structure of BadgeComponent to match recent updates to GlBadge
  • Adds new examples to the HAML Lookbook

I did run a semgrep to find all instances:

NO_COLOR=1 semgrep --lang=generic --pattern='Pajamas::BadgeComponent ... size:... ...' --include='*.html.haml' --include='*.rb' .
NO_COLOR=1 semgrep --lang=generic --pattern='gl_badge_tag ... size:... ...' --include='*.html.haml' --include='*.rb' .

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

Related to !129915 (merged), #457239 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading