Skip to content

Simplify vale rules

Marcel Amirault requested to merge docs-simplify-vale into master

What does this MR do?

While looking into our vale rules, I realized there's some duplication in our rules, and some rules can be simplified. We should also add some exclusions to reduce the number of warnings on some pages.

  • All the inclusive language rules have the same message, so might as well combine them all into one for easier management.
  • The outdated versions rule could be done with one simple regex, so let's clean that up.
  • Several pages list historical changes and likely won't have the old versions removed, so let's add the exclusion rules there to reduce the false positives.
  • doc/.vale/gitlab/Normal.yml has the same message as the substitution warning rule, so let's just keep it in there.

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Marcel Amirault

Merge request reports

Loading