Skip to content

Restore avatar for group/project member promotion requests

Kos Palchyk requested to merge 449139-fe-update-the-list-and-the-counter-after-inline-role-change-2 into master

What does this MR do and why?

After switching to GraphQL in !161044 (merged) — user avatars in Promotion requests tab had an issue, due to different id format in GraphQl and REST APIs. So in that MR I dropped the avatars, to add them back with a fix later. This MR adds them back with a fix.

Part of #449139 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Have an Ultimate License, and simulate Ultimate Self Managed setup (export GITLAB_SIMULATE_SAAS=0)
  2. Enable FF Feature.enable(:member_promotion_management)
  3. Go to admin settings / General / Sign-up restrictions and check the "Approve role promotions" checkbox
  4. Create promotion requests:
    1. Visit any Group members management page as an owner of that group (e.g. http://127.0.0.1:3000/groups/gitlab-org/-/group_members)
    2. try promoting a non-billable GUEST member to a DEVELOPER role (this member should be non-billable on the whole instance, i.e. have a highest role as guest, see !149094 (comment 1869616221) for details)
    3. you should see a banner saying "Role change request was sent to the administrator." — this means a promotion request has been created
  5. Switch to Promotion requests tab and see the member avatars
Edited by Kos Palchyk

Merge request reports