Skip to content

Add push/pull metrics for ml_model packages

Fred de Gier requested to merge 414270-add-metrics-for-ml_model-packages-upload into master

What does this MR do and why?

Instruments unique users pushing and pulling of ML Model packages

Adds i_package_ml_model_user to:

  • redis_hll_counters.user_packages.user_packages_total_unique_counts_weekly
  • redis_hll_counters.user_packages.user_packages_total_unique_counts_monthly

As without it this code fails and since ml_model is a package type it makes sense to align with the other packages. https://gitlab.com/gitlab-org/gitlab/blob/917a99ba81f885b29767ba9371c58eb59c4a641d/app/services/packages/create_event_service.rb#L13

::Packages::CreateEventService.new(Project.first, User.first, event_name: 'push_package', scope: :ml_model).execute

Gitlab::UsageDataCounters::HLLRedisCounter::UnknownEvent: Unknown event i_package_ml_model_user
from /Users/freddegier/gitlab-development-kit/gitlab/lib/gitlab/error_tracking.rb:82:in `track_and_raise_for_dev_exception'

Furthermore push and pull metrics for ml_model are added for both 7d and 28d.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Open Rails console
  2. Verify that the metric is 0
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pulled_weekly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pulled_monthly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pushed_weekly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pushed_monthly')
  1. Trigger a pull and push event for ML model
require_relative 'spec/support/helpers/service_ping_helpers.rb'
::Packages::CreateEventService.new(Project.first, User.first, event_name: 'pull_package', scope: :ml_model).execute
::Packages::CreateEventService.new(Project.first, User.first, event_name: 'push_package', scope: :ml_model).execute
  1. Verify that the metric has increased
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pulled_weekly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pulled_monthly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pushed_weekly')
ServicePingHelpers.get_current_usage_metric_value('counts.count_total_package_ml_model_pushed_monthly')

Numbered steps to set up and validate the change are strongly suggested.

Related to #414270 (closed)

Edited by Fred de Gier

Merge request reports