Skip to content

Refactor User::CreateService interface

Angelo Gulina requested to merge ag/466654-notify-alert-for-sm-bso-service-refactor into master

What does this MR do and why?

This MR is the first step of the iteration involved is tackling https://gitlab.com/gitlab-org/gitlab/-/issues/466654. The interface refactor is meant to consolidate the Refactor User::CreateService response as a ServiceResponse, able to return an error.

The next step will be the actual implementation of the feature (Notify Admin with alert when new User might gen... (!174231 - merged)).

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Angelo Gulina

Merge request reports