Skip to content

Use diff_blobs for streaming compare rapid diffs

Gavin Hinfey requested to merge 497557-use-diff-blobs-rpc-for-streaming-compare-diffs into master

What does this MR do and why?

Support for streaming diff_blobs for Merge Request rapid diffs was added in Add support for diff_blobs streaming for RapidD... (!162171 - merged).

This MR extends streaming support for diff_blobs to compare rapid diffs.

diff_blob performance comparison:

diff_blobs: false diff_blobs: true
average gitaly_duration_s 0.1028428 0.2511499

Similarly to streaming commit diffs using diff_blob, there is no performance improvement using the DiffBlob endpoint.

References

Similarly added diff_blobs for streaming commit rapid diffs here: !174863 (merged).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable the rapid_diffs feature flag.
  2. Create a new branch with multiple changes.
  3. Call the diffs_stream endpoint with the diff_blobs=true param. Eg http://gdk.test:3000/twitter/Typeahead.Js/-/compare/diffs_stream?from=master&to=new_branch_for_compare_test&offset=0&straight=true&diff_blobs=true.

Related to #497557 (closed)

Edited by Gavin Hinfey

Merge request reports