Skip to content

Connect vue app to api _links

Nicolò Maria Mezzopera requested to merge 33905-connect-paths-from-api into master

What does this MR do?

This MR connects details and delete actions to the urls returned by the API. This MR is part of the work outlined in !18860 (merged)

This MR is behind feature flag

Related backend MR: !20820 (merged)

Screencapture

screen-capture__24_

How to test

Feature flag to enable: :vue_package_list

Currently we have a fixture that will add 5 packages to a random 'starter' project in GDK. The project is one of the basic ones:

Screenshot_2020-01-08_at_13.36.37

What is supposed to work in this MR:

  • the list is loaded and display 5 packages
  • if the user can delete the package the delete button lights up and the delete works

If this is not a sufficient test scenario is possible to add more packages by following this procedure:

  1. checkout locally this repository: https://gitlab.com/nmezzopera/npm-package-starter
  2. follow the readme of the project
  3. verify the component in the project and group package page

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #33905 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports

Loading