The source project of this merge request has been removed.
Update diff line content on MR diffs to use actual HTML and not CSS element
What does this MR do?
On .com
, when viewing a MR diff, we have replaced the line number insertion from a CSS before
with actual HTML, rendered in the a
tag.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
Unit tested added to: diff_line_gutter_content_spec.js
to ensure a line number is rendered correctly by our component.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
References
Edited by Paul Slaughter