Skip to content

Geo Node Form in Vue - API/Validations

Zack Cuddy requested to merge 118841_05-node-form-api into master

Important Notes

This is the an MR broken off of !22719 (closed) This will allow for the MR to be easier to read and review without the giant MR all in one.

Work is towards the goal of #118841 (closed)

@sunjungp I reached out to the UX team with you being OOO to chat about the current styling of the form validations, and currently there is an effort to rework them. Right now it seems they are a little lacking, but we may see a change with that soon.

What does this MR do?

This MR adds API actions to create and update a Geo Node. This also adds form validation for the Name and URL field described here: #11326 (closed)

Significant Note: This will be final MR to add all required functionality for the Geo Form in Vue. After this we can create an MR to remove legacy code, remove the feature flag, and write up a release post!

This MR works behind the feature flag: :enable_geo_node_form_js

This feature flag will be removed as part of closing #118841 (closed)

This MR itself is an attempt at a MVC as well as to keep the MRs small around this overall change.

The end goal is to transition the Geo Node form into Vue along with additional form validations and updated styles.

Screenshots

Form Validations Form_Validations

GIFs

Create Node New_Node

Update Node Update_Node

Trigger onBlur Form Validations Form_Validations

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports