Skip to content

Clean mr_widget_options_spec from zombies

Paul Slaughter requested to merge 207376-clean-mr-widget-options-spec into master

What does this MR do?

Please see this comment for context.

This spec file was accidentally overwriting the reference to an already created component, which caused it to never be properly disposed. This MR:

  • Nests all of the current tests in a describe('default') so that we can move the createComponent outside the top-level beforeEach.
  • Moves the offending spec to their own describe context.
  • Installs the jasmine clock in the top-level beforeEach since this component kicks off polls on mount. There were actually a number of polls being created and never cleaned up 😬

References

Merge request reports