Geo Nodes - Conditional Removal Button
What does this MR do?
Closes #9682 (closed)
In Geo, you cannot remove the primary node without deleting the Secondary nodes. However, the UI does not reflect this. This MR adds a disabled check for the Removal button to disable removing a Primary node if Secondary nodes still exist.
A tooltip will pop up explaining the disabled button.
The positioning of the buttons was also moved to be inline with the top right of the card.
I also had to tweak a little bit of the scss
file for some breakpoint changes and a wrapper for the tooltip.
Screenshots
Desktop | Mobile | Tooltip | |
---|---|---|---|
before | NULL | ||
after |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
cc: @sunjungp Closes #9682 (closed)
Edited by Zack Cuddy