Skip to content

Refactor toast to alert in Image Repository details

What does this MR do?

This MR swap away from the toast message that informs the user about the successful (or not ) deletion of tags. The alert has an additional message if the user performing the deletion is an admin recommending him to run the garbage collection

In addition, this MR fixes an edge case with a ghost delete (if the user check the box of a row and then performs a single delete)

Screenshots

Succesful delete

As non-admin

Screenshot_2020-04-28_at_12.33.29

Screenshot_2020-04-28_at_12.32.31

As an Admin

Screenshot_2020-04-28_at_12.21.46

Screenshot_2020-04-28_at_12.20.45

Not successful delete (same for user and admin)

Screenshot_2020-04-28_at_12.31.29

Screenshot_2020-04-28_at_12.31.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #214477 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports

Loading