Skip to content

Generalize Geo Filter Bar

Zack Cuddy requested to merge 213219_03-generalize-geo-nav into master

What does this MR do?

This is work towards the final product proposed here: #213219 (closed)

In this effort we are combining views and navigation between them. This MR extracts the Filter component to a shared partial. This will allow other Geo Replicables that live in HAML to use this same component to stay up to spec with their counterparts.

As a POC it is implemented on the Projects View.

Following this MR, we will implement it to the Uploads view of Geo.

Screenshots

Filter Nav (No Change)
before Old
after New

GIFs

All existing functionality exists: Kapture_2020-04-27_at_12.55.55

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading