Generalize Geo Filter Bar
What does this MR do?
This is work towards the final product proposed here: #213219 (closed)
In this effort we are combining views and navigation between them. This MR extracts the Filter component to a shared partial. This will allow other Geo Replicables that live in HAML
to use this same component to stay up to spec with their counterparts.
As a POC it is implemented on the Projects View.
Following this MR, we will implement it to the Uploads view of Geo.
Screenshots
Filter Nav (No Change) | |
---|---|
before | |
after |
GIFs
All existing functionality exists:
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry - Will be done on full release of this feature when everything is merged together. See #213219 (closed)
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - Minus IE, but since this change is just moving code I think this is fine. - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy