Fix incorrect regex used in FileUploader#extract_dynamic_path
requested to merge 217602-file-uploads-on-local-storage-with-nil-secret-in-the-db-are-broken into master
What does this MR do?
We use upload.path for the fallback, and the matching regex has a / in the beginning, however, upload.path is relative, so it won't match them. This MR changes the regex to cover absolute and relative paths.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issues
Closes #217602 (closed)
Closes #215991 (closed)
Closes #217585 (closed)
Edited by Yorick Peterse