Skip to content

Set selectedLabels to empty array

Martin Wortschack requested to merge mw-cr-not-label-fix into master

What does this MR do?

We introduced not (!=) filters for Code Review Analytics in !31891 (merged).

This MR fixes a bug when no label_name is present and a not[label_name] filter gets applied. In this case, the selectedLabels array would have been undefined. With this fix we make sure that selectedLabels is set to an empty array in this case.

Screenshots

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports

Loading