Set selectedLabels to empty array
What does this MR do?
We introduced not
(!=
) filters for Code Review Analytics
in !31891 (merged).
This MR fixes a bug when no label_name
is present and a not[label_name]
filter gets applied. In this case, the selectedLabels
array would have been undefined. With this fix we make sure that selectedLabels
is set to an empty array in this case.
Screenshots
N/A
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack