Skip to content

Add time range to dashboard links

What does this MR do?

User-defined links in the dashboard yml file get rendered on the metrics dashboard as anchor elements. This MR adds the metrics dashboard's time range to the links.

Demo

https://gitlab-review-217736-add-tvu608.gitlab-review.app/root/monitor-sandbox/-/environments/1/metrics?dashboard=.gitlab%2Fdashboards%2Fmany_links.yml

Sample links for testing

few_links.yml links_with_long_titles.yml links_without_titles.yml links_without_urls.yml many_links.yml

Testing

  1. Navigate to the above dashboard
  2. Notice the first two links point to the monitor-sandbox dashboards.
  3. Update the time range for the dashboard and navigate to the monitor-sandbox dashboards via the links
  4. Observe that the time range info is passed over via the links.

Screenshots

links_with_time_range

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Mentions #217736 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading