SecurityReportSummary is null if report didn't run
What does this MR do?
In the case that there is a pipeline where some security reports have not run, those reports should return null when querying the securityReportSummary
For example, there is a pipeline where sast
is enabled and dast
is disabled. The following query:
query{
project(fullPath: "root/rails-goat"){
pipeline(iid: "22"){
securityReportSummary{
dast{
scannedResourcesCount
vulnerabilitiesCount
}
sast{
vulnerabilitiesCount
}
}
}
}
}
should return
{
"data": {
"project": {
"pipeline": {
"securityReportSummary": {
"dast": null,
"sast": {
"vulnerabilitiesCount": 317
}
}
}
}
}
}
This MR partially resolve #223073 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Craig Smith