Skip to content

SecurityReportSummary is null if report didn't run

Craig Smith requested to merge hide_scans_that_have_not_run_223673 into master

What does this MR do?

In the case that there is a pipeline where some security reports have not run, those reports should return null when querying the securityReportSummary

For example, there is a pipeline where sast is enabled and dast is disabled. The following query:

query{
  project(fullPath: "root/rails-goat"){
    pipeline(iid: "22"){
      securityReportSummary{
        dast{
          scannedResourcesCount
          vulnerabilitiesCount
        }
        sast{
          vulnerabilitiesCount
        }
      }
    }
  }
}

should return

{
  "data": {
    "project": {
      "pipeline": {
        "securityReportSummary": {
          "dast": null,
          "sast": {
            "vulnerabilitiesCount": 317
          }
        }
      }
    }
  }
}

This MR partially resolve #223073 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Craig Smith

Merge request reports

Loading