Fix extra cycle analytics data request
What does this MR do?
While fixing !37336 (merged) I noticed duplicate dispatches for the FETCH_CYCLE_ANALYTICS_DATA
. This action sends requests to multiple endpoints:
/groups/:group_id/-/analytics/value_stream_analytics/stages
/groups/:group_id/-/analytics/value_stream_analytics/value_streams
/analytics/value_stream_analytics/stages/:staged_id/median
/analytics/value_stream_analytics/stages/:stage_id/duration_chart
It looks like this was introduced in 47be8411
This causes extra requests to be sent for the same data and increases the time for initial load.
Testing
- Browse to group VSA, for example
/groups/gitlab-org/-/analytics/value_stream_analytics
, or by navigating to a group and then selectingAnalytics > Value Stream
in the menu
- In the network panel observe the requests being sent (filtering the requests will help)
- If you have the vuex browser extension you can see that a single
FETCH_CYCLE_ANALYTICS_DATA
request is dispatched
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #225660 (closed)
Edited by Ezekiel Kigbo