Skip to content

Fix extra cycle analytics data request

Ezekiel Kigbo requested to merge 225660-fix-duplicate-fetch-data-request into master

What does this MR do?

While fixing !37336 (merged) I noticed duplicate dispatches for the FETCH_CYCLE_ANALYTICS_DATA. This action sends requests to multiple endpoints:

  • /groups/:group_id/-/analytics/value_stream_analytics/stages
  • /groups/:group_id/-/analytics/value_stream_analytics/value_streams
  • /analytics/value_stream_analytics/stages/:staged_id/median
  • /analytics/value_stream_analytics/stages/:stage_id/duration_chart

It looks like this was introduced in 47be8411

This causes extra requests to be sent for the same data and increases the time for initial load.

Testing

  1. Browse to group VSA, for example /groups/gitlab-org/-/analytics/value_stream_analytics, or by navigating to a group and then selecting Analytics > Value Stream in the menu

Screen_Shot_2020-07-23_at_12.45.45_am

  1. In the network panel observe the requests being sent (filtering the requests will help)
  2. If you have the vuex browser extension you can see that a single FETCH_CYCLE_ANALYTICS_DATA request is dispatched

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225660 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading