Feat(Code Review): use general filter bar
What does this MR do?
This MR changes the Analytics Code Review page to use the general filtered_search_bar.vue instead of our own implementation.
This is a stepping stone towards implementing a general filter bar solution for analytics.
In changing to use this general implementation, we get recent searches feature for free, which resolves this ticket for us #217720 (closed)
Screenshots
Before: | After: |
---|---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry Not needed as this is still behind a feature flag, which is being rolled out in a different MR
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
This implementation is fairly safe as it uses a component that is in use in other places, over a specific implementation of the same. The feature tests also pass with very few modifications, which is reassuring.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #232465 (closed) Closes #217720 (closed)