Skip to content

Feat(Code Review): use general filter bar

What does this MR do?

This MR changes the Analytics Code Review page to use the general filtered_search_bar.vue instead of our own implementation.

This is a stepping stone towards implementing a general filter bar solution for analytics.

In changing to use this general implementation, we get recent searches feature for free, which resolves this ticket for us #217720 (closed)

Screenshots

Before: After:
Screen_Shot_2020-08-07_at_14.27.17 Screen_Recording_2020-08-07_at_14.36.34

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This implementation is fairly safe as it uses a component that is in use in other places, over a specific implementation of the same. The feature tests also pass with very few modifications, which is reassuring.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #232465 (closed) Closes #217720 (closed)

Edited by Michael Lunøe

Merge request reports

Loading