Skip to content

Resolve "Cannot cancel creation of new release"

Jake Burden requested to merge 235515-cannot-cancel-creation-of-new-release into master

What does this MR do?

Resolves a bug where the cancel button doesn't work on new releases page: #235515 (closed)

This MR adds releases_page_path: project_releases_path(@project) to the dataset sent to the -/releases/new page. The releases_page_path attribute is then used to create the cancelPath used on the cancel button:

cancelPath() {
  return getParameterByName(BACK_URL_PARAM) || this.releasesPagePath;
},

Source: https://gitlab.com/gitlab-org/gitlab/-/blob/35f17fe089ad63c91736b05fa58027c200ae2543/app/assets/javascripts/releases/components/app_edit_new.vue#L80

Screenshots

GIF showing that the back button works

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #235515 (closed)

Edited by Jake Burden

Merge request reports

Loading