Migrate custom Tabs to GlTabs
requested to merge 230719-tabs-vue-migrate-app-assets-javascripts-environments-components-environments_app-vue-to into master
What does this MR do?
Following up on #230719 (closed), this MR simply:
- removes the custom Tabs implementation to introduce
GlTabs - updates the CSS classes to use GitLab UI utilities
Additionally, it avoids reloading the scope data when clicking on the currently active one (see video).
Screenshots
| Mobile | Desktop |
|---|---|
 |
 |
| before | after |
|---|---|
| reload | reload-no-more |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina