Skip to content

Remove unnecessary content_for? checks

Lukas Eipert requested to merge 258972-remove-unnecessary-content-for-check into master

What does this MR do?

Not-blocking: I think you don't need the if condition. If there is no content for page_specific_styles it would just render nothing

We are checking whether we have any content before we yield content blocks. This is unnecessary, because if the content block is empty, it'll simply yield an empty string.

Furthermore it seems like the content block library_javascripts is unnecessary can be deprecated in favor of page_specific_javascripts.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #258972 (closed)

Edited by Lukas Eipert

Merge request reports

Loading