Skip Bootrap popover initialization in app/views/projects/blob/new.html.haml
What does this MR do?
In this particular case, we are initializing a GlPopover instance on the .js-suggest-gitlab-ci-yml-commit-changes selector, see lines 136 and 157 in app/assets/javascripts/blob/file_template_mediator.js.
However the HAML adds the data-toggle="popover" attribute to the element, which includes it in Bootstrap's initialization script in app/assets/javascripts/main.js.
It should be safe to remove the data attribute to bypass Bootstrap entirely for that popover, and to rely solely on the GlPopover implementation.
Screenshots
There is no noticeable difference as we're only removing a redundant attribute, the result in functionally the same.
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #251105 (closed)