Skip to content

Fix confusing button text when importing from GitHub

What does this MR do?

This MR fixes the text of the 'import all' button on the GitHub import page. When the user starts any import, the text of the "Import x repositories" button will change to "Importing..."

I think that it's better when the spinner remains. But I'm wondering whether we can only make the button loading/disabled when importAll is run (i.e. the "import x repositories" button is clicked and then the confirm button in the modal). Because technically, importAll should only run not started repository imports, right? (question @ reviewer)

Related to #285634 (closed)

Screenshots (strongly suggested)

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports

Loading