Fix confusing button text when importing from GitHub
requested to merge KevSlashNull/gitlab:285634-Fix-confusion-button-text-when-importing-from-github into master
What does this MR do?
This MR fixes the text of the 'import all' button on the GitHub import page. When the user starts any import, the text of the "Import x repositories" button will change to "Importing..."
I think that it's better when the spinner remains. But I'm wondering whether we can only make the button loading/disabled when importAll
is run (i.e. the "import x repositories" button is clicked and then the confirm button in the modal). Because technically, importAll
should only run not started repository imports, right? (question @ reviewer)
Related to #285634 (closed)
Screenshots (strongly suggested)
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev