Skip to content

Move project members into tabs

What does this MR do?

Related to #281824 (closed)

This is the first step in giving the project members view the same treatment that was given to the group members view in &4233 (closed).

This MR reorganizes the project members into tabs. We are not using the GitLab UI tabs yet, but we are planning on migrating to those once the Vue app is all setup. The reason for this being that the group members view is not yet using the GitLab UI tabs either so it will be easier to migrate both of the views at the same time since they use shared Vue components.

Screenshots (strongly suggested)

Desktop

Page Before After
Members tab Screen_Shot_2020-12-16_at_5.06.35_PM Screen_Shot_2020-12-16_at_4.56.15_PM
Groups tab N/A Screen_Shot_2020-12-16_at_4.56.31_PM
Invites tab N/A Screen_Shot_2020-12-16_at_4.56.46_PM
Access requests tab N/A Screen_Shot_2020-12-16_at_4.57.01_PM

Mobile

Page Before After
Members tab 127.0.0.1_3000_flightjs_flight_-project_members_iPhone_6_7_8___1 Screen_Shot_2020-12-16_at_4.57.38_PM
Groups tab N/A Screen_Shot_2020-12-16_at_4.57.53_PM
Invites tab N/A Screen_Shot_2020-12-16_at_4.58.05_PM
Access requests tab N/A Screen_Shot_2020-12-16_at_4.58.16_PM

Local testing

  1. Create a project
  2. Navigate to Project -> Members

How to add a group

  1. Navigate to Project -> Members
  2. Click the Invite group tab

How to add an invited member

  1. Navigate to Project -> Members
  2. In the GitLab member or Email address enter an email that a user does not already own
  3. Click Invite "example@test.com" by email

How to request access to a project

  1. Log in (or impersonate) a user that doesn't already have access to the group
  2. Navigate to the project overview
  3. Click Request access located below the project name

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading