Skip to content

Improve search filter by taking space in file path into account

Changzheng Liu requested to merge 281677_space_in_filename into master

What does this MR do?

This MR changes how to tokenize the input search strings. Before this change, we split the string by whitespace. If whitespace exists in a path of a file, for example foo path:"my test.txt", it produces ["foo", 'path:"my', 'test.txt"']. It's very likely it won't find a path matching "my.

The change is to not break words inside double-quotes.

This is related to #281677 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Changzheng Liu

Merge request reports

Loading