Refactoring: Move search settings mount function to the search_settings directory
- WIP Full Context MR
- Refactoring: Move search settings mount function to the search_settings directory (merged)
- Fix flashy search box when loading a settings page (merged)
- Add enable_search_settings_helper (merged)
- Separate sections in user settings pages layout (merged)
- Add search to user settings
- Document search settings
- Settings search bar to remember expansion state
- Add search to admin settings
What does this MR do?
It moves the function that mounts the Search Settings component to the search_settings
directory. Why We are integrating the Search settings component into all Settings pages. The logic to asynchronously load the Search Settings component based on the presence of a feature flag is the same in all instances.
We’ve moved this logic from the context specific pages
directory to the search_settings
directory.
Screenshots (strongly suggested)
This change does not introduce user-facing changes.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Slaughter