Skip to content

Collapse Deployments in Merge Request if Many

What does this MR do?

If there are more than 4 deployments an MR has been deployed to (either pre- or post-merge), put them in a collapsible container and collapse it by default.

This does require a bit of expansion on the MrCollapsibleContainer slightly, providing a slot to add "header text" (I will accept name suggestions), which is not blue nor clickable. This was done without touching the current slot or props, and should be completely backwards compatible.

For #294172 (closed)

Screenshots (strongly suggested)

image

image

image

Testing

Want to play with this feature? You can download this patch and apply it.

I recommend calling curl https://gitlab.com/gitlab-org/gitlab/uploads/48f0bb76846a7491c1a962d38550f6b0/testing.patch | git apply.

Add and remove environment blocks at your leisure, but they must have a unique ID. Remember that collapsing only occurs if there are greater than 3 environments.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrew Fontaine

Merge request reports

Loading