Skip to content

Update compliance framework list deleting

Jiaan Louw requested to merge 322132-update-delete-compliance-frameworks into master

What does this MR do?

This updates the compliance framework list to show loading on multiple list items when they are being deleted to resolve #322132 (closed).

Setup & Testing

  1. Enable the feature flag in rails console: Feature.enable(:ff_custom_compliance_frameworks)
  2. Add compliance framework(s)
  3. Delete compliance framework(s)

Screenshots (strongly suggested)

No real visual change beyond supporting multiple loading states on the delete button.

Compliance Frameworks
image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322132 (closed)

Edited by Jiaan Louw

Merge request reports

Loading