Skip to content

Update lint:eslint to not hardcode "."

Paul Slaughter requested to merge ps-update-eslint-job-not-to-hardcode-dir into master

What does this MR do?

As a developer, I'm much more interested in running eslint against a subset of files rather than all files. Currently there is no easy way to do this in our package.json scripts. Let's repurpose the lint:eslint job to not include a specific directory so the developer can control this.

This MR also:

  • Updates the previous references to yarn run lint:eslint to yarn run lint:eslint:all
  • Updates the previous references to yarn run internal:eslint to yarn run lint:eslint

Screenshots (strongly suggested)

Look how fast and easy it is now! 🎉

Screen_Shot_2021-03-01_at_3.00.40_PM

Previously, this takes a really long time because the lint:eslint job is coupled to running the entire project directory.

Edited by Paul Slaughter

Merge request reports

Loading