Skip to content

Create UserAccessRoleBadge component

Tom Quirk requested to merge user-access-role-badge-component into master

What does this MR do?

Adds a new component user_access_role_badge.vue that transparently wraps GlBadge, but applies specific styling not available in GlBadge variants (issue in gitlab-ui to discuss this: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1247).

This new component is then used to replace any elements that used the .user-access-role class in Vue components, namely:

  • groups
  • comments (that use noteable_note.vue)
  • groups, when forking a project

It will also be used in comments on Jira issues (within GitLab) in a future MR (!55814 (comment 524041723)) as part of #322638 (closed).

Screenshots (strongly suggested)

Groups

Before After
Screen_Shot_2021-03-09_at_1.25.02_pm Screen_Shot_2021-03-09_at_12.00.53_pm

Groups (when forking a project)

Before After
Screen_Shot_2021-03-09_at_1.25.28_pm Screen_Shot_2021-03-09_at_12.00.23_pm

Comments/notes

Before After
Screen_Shot_2021-03-09_at_1.26.04_pm Screen_Shot_2021-03-09_at_11.28.12_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading