Create UserAccessRoleBadge component
What does this MR do?
Adds a new component user_access_role_badge.vue
that transparently wraps GlBadge
, but applies specific styling not available in GlBadge
variants (issue in gitlab-ui to discuss this: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1247).
This new component is then used to replace any elements that used the .user-access-role
class in Vue components, namely:
- groups
- comments (that use
noteable_note.vue
) - groups, when forking a project
It will also be used in comments on Jira issues (within GitLab) in a future MR (!55814 (comment 524041723)) as part of #322638 (closed).
Screenshots (strongly suggested)
Groups
Before | After |
---|---|
Groups (when forking a project)
Before | After |
---|---|
Comments/notes
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk