Skip to content

Refactor UserInternalRegexHandler to own module

Paul Slaughter requested to merge ps-refactor-user-internal-regex-handler into master

What does this MR do?

This MR refactors a class which was exported from a page module. Previously:

  • The tests which imported this module had a side-effect on import
  • The class used jquery

With this MR:

  • This class has been refactored into a function that lives in a module outside the pages directory.
  • It no longer uses jquery.

Screenshots (strongly suggested)

Everything still works! 🎉

20210317_admin_users_new_demo

  • When email matches "internal user regex", then we automatically uncheck the "external" checkbox and show a warning message
  • This warning message is hidden when the checkbox is changed by the user

Does this MR meet the acceptance criteria?

Conformity

Merge request reports

Loading