Remove unused js class [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Remove unused js class
This change removes the class js-title-container
from the breadcrumbs.
This js-* class is not used except for a single quarantined test. This change also updates the test when it is taken out of quarantine it still passes.
- Added a testid that is more semantic:
data-testid="breadcrumb-links"
- Replaced the occurrence of .js-title-container with this
- Update the feature spec that depended on the CSS class
.breadcrumb-links
Screenshots (strongly suggested)
This is the related element in the page:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this is change to only impacts our internal specs.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon