Skip to content

Remove unused js class [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Miguel Rincon requested to merge mrincon-remove-js-title-container into master

What does this MR do?

Remove unused js class

This change removes the class js-title-container from the breadcrumbs.

This js-* class is not used except for a single quarantined test. This change also updates the test when it is taken out of quarantine it still passes.

  • Added a testid that is more semantic: data-testid="breadcrumb-links"
  • Replaced the occurrence of .js-title-container with this
  • Update the feature spec that depended on the CSS class .breadcrumb-links

Screenshots (strongly suggested)

This is the related element in the page:

Screen_Shot_2021-03-24_at_3.56.08_PM

Screen_Shot_2021-03-24_at_3.57.08_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports

Loading