Fix missing border for incident issues
What does this MR do?
The smallest MVC possible for: #326244 (closed) where we allow the bottom border to be drawn under milestones on incident issues to create alignment with issues.
This is done using a condition check on issuable_sidebar[:supports_iterations]
, and the reason we use this is that this evaluates to: !incident?
which lets us target the incident details page leaving Epics, issues and merge details unaffected.
Screenshots (strongly suggested)
Issue | Merge | Incident |
---|---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. - [-] I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #326244 (closed)
Edited by David O'Regan