Skip to content

Fix missing border for incident issues

David O'Regan requested to merge 326244-incident-sidebar-milestome into master

What does this MR do?

The smallest MVC possible for: #326244 (closed) where we allow the bottom border to be drawn under milestones on incident issues to create alignment with issues.

This is done using a condition check on issuable_sidebar[:supports_iterations], and the reason we use this is that this evaluates to: !incident? which lets us target the incident details page leaving Epics, issues and merge details unaffected.

Screenshots (strongly suggested)

Issue Merge Incident
Screenshot_2021-04-06_at_09.40.06 Screenshot_2021-04-06_at_09.40.14 Screenshot_2021-04-06_at_09.40.24

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #326244 (closed)

Edited by David O'Regan

Merge request reports

Loading