Add logging for legacy usage of ProcessPipelineService#update_retried
What does this MR do?
- Our goal: We want to remove the outdated method
Ci::ProcessPipelineService#update_retried. - What's done: We fixed some places that still need this code. (see the related MRs in #326791 (closed))
- What's remaining: We still have small number of usages. (see the comment: #326791 (comment 554671746))
In this MR, we add logging to detect why we still have those usages.
Example;
{"severity":"INFO","time":"2021-04-28T12:15:30.956Z","correlation_id":"01F4C6FQ6R6NJY0F1Y461S5DNA","event":"update_retried_is_used","project_id":12345,"pipeline_id":6789}
{"severity":"INFO","time":"2021-04-28T12:15:33.287Z","correlation_id":"01F4C6FSJQABVZ62VEGS8AA3FM","event":"update_retried_is_used","project_id":12345,"pipeline_id":6789}Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is not user-facing.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan