Subscription Activation Modal: Create Modal Component
What does this MR do?
This MR is part of a larger work towards implementing the feature described in gitlab-org/gitlab#328246. In this MR we're implementing the modal and the related tests.
The modal won't be plugged though because of an ongoing conversation regarding some of the conditions to show the button that would trigger it (if interested, see here)
Use the mutation data to update the current subscription | !60577 (merged) |
Generalise Activation Form | !60628 (merged) |
Create the modal reusing the Activation Form |
|
Plug the Activation Modal and add the mutation for the subscription list | tbd |
Write feature specs | tbd |
A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.
To test the changes locally
-
Delete any previous license you might have
-
Make sure you have set the following environment vars (usually in your terminal) and restart
gdk
-
GITLAB_LICENSE_MODE
is set totest
-
CUSTOMER_PORTAL_URL
is set tohttps://customers.stg.gitlab.com
-
-
Use Rails console to run
ApplicationSetting.current.update(cloud_license_enabled: true)
-
Navigate to
admin/cloud_license
-
Use the following activation code:
Lx6XhhLR1jSj2aacuZFRP8Mf
-
To test the failing scenario (connectivity Issue), set
CUSTOMER_PORTAL_URL
tohttps://fakeaddress
and proceed with the activation.
Screenshots (strongly suggested)
The screenshots are for illustration purpose, the MR does not contain substantial UI changes.
Genreal Error | Connectivity Error |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because the changes have no UI impact.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team