Skip to content

Bust the cache for /whats-new

Jay requested to merge jswain_whats_new_stale_content into master

What does this MR do?

Using a query param to bust the cache on requests to /whats-new. While I haven't personally experienced a cacheing issue, it has been reported that the count and notification bubble are correct, though when loading the "What's New" module, the content is stale.

Initially I combed over the cache headers, thinking maybe something was missed there, but the headers seem correct. And given I can't reproduce the experience, this issue is difficult to solve.

I chose this simple approach to see if it solves the issue, though I'm open to other solutions.

part of: #325899 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jay

Merge request reports

Loading