Skip to content

Fix missing data and class in top_nav_menu_item

What does this MR do?

This MR updates the top_nav_menu_item to actually render the css_class and data it gets from the view model. This fixes a number of things:

  • Fixes "Leave Admin Mode" not working since it needs data-method="post"
  • Fixes missing QA selectors

Screenshots (strongly suggested)

How to test?

  • Make sure combined_menu feature flag is enabled
  • Sign in to the admin user
  • Visit the admin settings page and activate the Admin mode checkbox

Screen_Shot_2021-05-19_at_3.41.31_PM

  • Hit Menu > Enter Admin Mode
  • Type in password
  • Hit Menu > Leave Admin Mode
Before (on master) After (this MR)
Screen_Shot_2021-05-19_at_3.44.13_PM Screen_Shot_2021-05-19_at_3.47.38_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

References

Related to #301143 (closed)

Edited by Paul Slaughter

Merge request reports

Loading