Skip to content

Update startup css which fixes login pages

Paul Slaughter requested to merge ps-update-startup-css into master

What does this MR do?

This MR is the user-facing part of !61635 (closed), which updates the startup css files that haven't been updated in a while 😬

This is also needed for the upcoming top nav and left sidebar refactor.

Screenshots (strongly suggested)

How to test?

You can either:

  1. Simply open a page locally and check for any significant style changes while the application.css loads.
  2. Try applying the following patch and visiting a page with ?startup_css_only=true to prevent the application.css from loading. You can then compare this page with one that does not have the ?startup_css_only parameter and compare for differences.

0001-Add-startup_css_only-condition.patch

Desc Before (on master with ?startup_css_only=true) After (this MR with ?startup_css_only=true) After (this MR)
Sign in signin_before_startup_css signin_after_startup_css signin_after_full
Register register_before_startup_css register_after_startup_css register_after_full
With :combined_menu disabled ff_off_before_startup_css ff_off_after_startup_css ff_off_after_full
With :combined_menu enabled ff_on_before_startup_css ff_on_after_startup_css ff_on_after_full
Dark mode dark_before_startup_css dark_after_startup_css dark_after_full

To just double check we're not making any huge visual regressions, here's a smoke test of a few random pages

MR page Search
mr_after_full search_after_full

Does this MR meet the acceptance criteria?

Conformity

Edited by Paul Slaughter

Merge request reports

Loading