Skip to content

Style polish for top nav redesign

Paul Slaughter requested to merge 301143-polish-for-top-nav-redesign into master

What does this MR do?

This MR addresses the UX polish feedback over in this comment:

  • The padding between icon and text is only 4px, I think we usually have 8px for these cases.
  • Border should be using #F0F0F0 $gray-50 instead of #bfbfbf
  • Hover state of the frequently visited items should match other menu hover state. The frequently visited items is missing border radius.
  • The 12px x 8px button padding will not be changed because it's part of the component's standard padding !63241 (comment 592330599)
  • We will change the color of the frequent items item titles in a follow-up

Screenshots (strongly suggested)

Description Before After
With Feature.disable(:combined_menu), notice that we technically change the border radius of the buttons f_off_before ff_off_after
With feature enabled, notice that the border radius of the frequent items has changed. ff_on_before ff_on_after
With feature enabled on mobile, notice the border radius ff_on_mobile_before ff_on_mobile_after
With feature enabled, notice the separator color ff_on_separator_before ff_on_separator_after
With feature enabled, notice the spacing between icon and text ff_on_icons_before ff_on_icons_after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Paul Slaughter

Merge request reports

Loading